Correct state usage in StepS. Remove hoist shenanigans#285
Merged
gpampara merged 1 commit intociren:masterfrom May 21, 2018
Merged
Correct state usage in StepS. Remove hoist shenanigans#285gpampara merged 1 commit intociren:masterfrom
gpampara merged 1 commit intociren:masterfrom
Conversation
gpampara
force-pushed
the
steps-usage-cleanup
branch
from
8917205 to
2d31759
Compare
filinep
previously approved these changes
May 21, 2018
It's better to interact with the state in the StepS transformer using a MonadState MTL-like typeclass. It reduces a fair amount of noise and makes the inference much simpler.
gpampara
force-pushed
the
steps-usage-cleanup
branch
from
2d31759 to
8418b18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's better to interact with the state in the StepS transformer using
a
MonadStatemtl-like typeclass. It reduces a fair amount of noise andmakes the inference much simpler.