Pass the Eval to onChange for environment handling#290
Merged
gpampara merged 8 commits intociren:masterfrom Jul 20, 2018
Merged
Pass the Eval to onChange for environment handling#290gpampara merged 8 commits intociren:masterfrom
gpampara merged 8 commits intociren:masterfrom
Conversation
When a dynamic environment changes, some handling mechanisms require a modification to the entity collection. A trivial example would be that the fitness values are potentially no longer valid for the entity collection after an environment change.
gpampara
changed the title
stefanvds
previously approved these changes
Jul 15, 2018
stefanvds
left a comment
stefanvds
left a comment
There was a problem hiding this comment.
The changes directly address the stated issue, allowing the eval from the Environment to be passed to the onChange function in the Runner. This change will allow dynamic environments to react correctly to environment landscape changes by adapting in any way as deemed appropriate by the user. The change cascades into some optimization in the Environment codebase. All usages (i.e. in the examples folder had to be updated as well.
filinep
previously approved these changes
Jul 16, 2018
Really need a way to do this automatically...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a dynamic environment changes, some handling mechanisms require
a modification to the entity collection. A trivial example would be
that the fitness values are potentially no longer valid for the entity
collection after an environment change.