Conversation
This should result in a quite noticeable improvement to the speed of execution.
The speed increase is quite noticeable for the example PSO executions. For the LBest and GBest the execution time has nearly been halved which is more than what was expected!
gpampara
force-pushed
the
non-empty-vector
branch
from
06c3753 to
4c54439
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR translates the use of
NonEmptyListfor a more specialisedNonEmptyVectorthat wraps theChunkfromzio.The result is a large performance increase with lower memory usage because
Chunks do not box primitives and are array-based. Thezio.NonEmptyChunkis not used because it exposes some unsafe operations for the context of cilib and we therefore replicate the type internally without allowing the implicit conversion toChunkfromNonEmptyChunk.