Add github.com keys to ~/.ssh/known_hosts
#200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edigaryev
reviewed
Jan 6, 2025
templates/base.pkr.hcl
Outdated
| "source ~/.zprofile", | ||
| "[[ ! -d ~/.ssh ]] && mkdir ~/.ssh 2>/dev/null", | ||
| "chmod 777 ~/.ssh", | ||
| "ssh-keyscan -t rsa,ecdsa,ed25519 github.com >> ~/.ssh/known_hosts", |
Contributor
There was a problem hiding this comment.
I don't think this is secure, as there's always possibility of MITM 🤔
How about we add static ~/.ssh/known_hosts from GitHub's SSH key fingerprints
help article instead?
edigaryev
reviewed
Jan 6, 2025
templates/base.pkr.hcl
Outdated
| // Add GitHub to known hosts | ||
| // Similar to https://github.com/actions/runner-images/blob/main/images/macos/scripts/build/configure-ssh.sh | ||
| provisioner "file" { | ||
| source = "github_known_hosts" |
Contributor
There was a problem hiding this comment.
Should it point to data/github_known_hosts? 🤔
edigaryev
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.