Merged
Conversation
jsf9k
approved these changes
Jun 17, 2022
- packer from 1.7.10 to 1.8.2 - shfmt from 3.4.3 to 3.5.1 - terraform from 1.1.6 to 1.2.3 I checked the CHANGELOGs for each of these updates and saw no breaking changes. Additionally we have likely been using newer versions in local testing and deployment already so this simply makes our GitHub Actions configuration up-to-date.
mcdonnnj
force-pushed
the
maintenance/update_versions
branch
from
e2d230f to
d0b52d6
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates the versions of three pieces of software used in our linting/testing configurations as follows:
💭 Motivation and context
It's good to stay up-to-date on the versions we use in the GitHub Actions environment as we have likely been using newer versions in local testing and deployment already. I checked the CHANGELOGs for each of these updates and saw no breaking
changes.
🧪 Testing
Automated tests pass. I checked this branch in cisagov/cool-assessment-terraform and cisagov/kali-packer to verify no unexpected failures.
✅ Pre-approval checklist
✅ Pre-merge checklist