Merged
Conversation
Add isort configuration file.
Add isort tool to pre-commit hooks.
…provements/pull_in_upstream_and_run_isort
… not currently support coverage 5.0+ per TheKevJames/coveralls-python#203
felddy
approved these changes
Jan 6, 2020
Contributor
felddy
left a comment
There was a problem hiding this comment.
Nifty! You sort, iSort, we all sort!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR is an update to #29 where, after feedback from @jsf9k , the inclusion of
isortwas pushed upstream into cisagov/skeleton-generic. Thus this PR includes upstream changes and updates after runningpre-committo runisortagainst the repository.💭 Motivation and Context
It would be beneficial for future Python projects, and any that update from upstream, to get the benefits of adding
isortto ourpre-commithooks.🧪 Testing
After pulling in from upstream and running
pre-commitapytestrun had no failures.📷 Screenshots (if appropriate)
🚥 Types of Changes
✅ Checklist