Skip to content

Pull in Upstream and Run pre-commit#30

Merged
mcdonnnj merged 5 commits intodevelopfrom
improvements/pull_in_upstream_and_run_isort
Jan 6, 2020
Merged

Pull in Upstream and Run pre-commit#30
mcdonnnj merged 5 commits intodevelopfrom
improvements/pull_in_upstream_and_run_isort

Conversation

@mcdonnnj
Copy link
Copy Markdown
Member

🗣 Description

This PR is an update to #29 where, after feedback from @jsf9k , the inclusion of isort was pushed upstream into cisagov/skeleton-generic. Thus this PR includes upstream changes and updates after running pre-commit to run isort against the repository.

💭 Motivation and Context

It would be beneficial for future Python projects, and any that update from upstream, to get the benefits of adding isort to our pre-commit hooks.

🧪 Testing

After pulling in from upstream and running pre-commit a pytest run had no failures.

📷 Screenshots (if appropriate)

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcdonnnj mcdonnnj requested review from dav3r and jsf9k December 23, 2019 17:27
@mcdonnnj mcdonnnj requested review from a team and felddy as code owners December 23, 2019 17:27
@mcdonnnj mcdonnnj self-assigned this Dec 23, 2019
@mcdonnnj mcdonnnj mentioned this pull request Dec 23, 2019
9 tasks
Copy link
Copy Markdown
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellenté! 🔊

Copy link
Copy Markdown
Contributor

@felddy felddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nifty! You sort, iSort, we all sort!

@mcdonnnj mcdonnnj merged commit 2fcac8e into develop Jan 6, 2020
@mcdonnnj mcdonnnj deleted the improvements/pull_in_upstream_and_run_isort branch January 6, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants