Fix for route map src proto sorting #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for fixing PUPPET JIRA Issue: https://tickets.puppetlabs.com/browse/CISCO-80.
The problem here is that the show command output for routemap match source protocol is different in different versions of software (it is neither sorted nor follows any pattern).
The fix is to always sort the output (irrespective of the input) and compare it with sorted input.
Note that this is only an issue with test code, the actual puppet resource command always sorts before comparing (done in the puppet type code) so there is no idempotent issue.
Tested on different platforms and different versions.