minitest n6k: test_vni dependency #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* n6k has feature-set fabricpath dependency * Added getter/setter to feature.rb
mikewiebe
reviewed
Feb 7, 2019
| # Get current state of the feature-set | ||
| feature_set_installed = Feature.fabricpath_installed? | ||
|
|
||
| config("no #{fs} ; no install #{fs}") if feature_set_installed |
Contributor
There was a problem hiding this comment.
nit Why not just call Feature.fabricpath_installed? directly here?
Contributor
Author
There was a problem hiding this comment.
This test is just a copy/paste/rename from the other feature-set tests. I think the reason I used config() here back in the day was because it's marginally faster to send both commands at once.
Contributor
There was a problem hiding this comment.
I was not concerned about config(). I was suggesting you get rid of line 235 feature_set_installed = Feature.fabricpath_installed? and just do this.
config("no #{fs} ; no install #{fs}") if Feature.fabricpath_installed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested both testcases on n6k, n7k, n9k