Skip to content

Proof of concept: Adds file validator and screens check#201

Closed
sverhoeven wants to merge 9 commits intomainfrom
file-validation
Closed

Proof of concept: Adds file validator and screens check#201
sverhoeven wants to merge 9 commits intomainfrom
file-validation

Conversation

@sverhoeven
Copy link
Copy Markdown
Collaborator

@sverhoeven sverhoeven commented Aug 23, 2021

Pull request details

Tryout file validator and mapping it to fields and screens.

Compared to approach in #206

  • pro: finds validation errors that go beyond the rules available to single scalar field like required or duplication
  • pro: runs validation once instead of for each field, each screen and file
  • pro: retains validation errors
  • con: uses end result to validate field
  • con: show validation from start

List of related issues or pull requests

Refs: #197 #166, #165

Describe the changes made in this pull request

Instructions to review the pull request

@sverhoeven sverhoeven marked this pull request as draft August 24, 2021 06:48
@jspaaks jspaaks added the standup Items you want to discuss during standup label Oct 26, 2021
@fdiblen
Copy link
Copy Markdown
Member

fdiblen commented Oct 27, 2021

Superseded by #307

@fdiblen fdiblen closed this Oct 27, 2021
@fdiblen fdiblen removed the standup Items you want to discuss during standup label Oct 27, 2021
@fdiblen fdiblen deleted the file-validation branch October 27, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants