Merged
Conversation
add red border when there is a problem
improve styling for authors screen and preview validation
|
✔️ Deploy Preview for cffinit ready! 🔨 Explore the source changes: 503f754 🔍 Inspect the deploy log: https://app.netlify.com/sites/cffinit/deploys/61794b55673bd4000700c851 😎 Browse the preview: https://deploy-preview-307--cffinit.netlify.app |
sverhoeven
reviewed
Oct 20, 2021
Implement validation for start screen. Clean up the validation on all screens except start screen.
replace keys with empty strings with undefined state of the app and state of the generated cff are more similar simplify deep-filter function by only filtering undefined objects/keys implement validation for authors and start screens fix the indexing problem for authors screen add error message banner change initial and reset states of cff object
…165-new-validation-filter
sverhoeven
reviewed
Oct 25, 2021
Show object level errors for each author Add red border to AuthorCardEditing and AuthorCardViewing when there is an error Add 'minItems' check to validator Remove duplicate error messages Hide error messages related to entity author entries
This was referenced Oct 27, 2021
Closed
This was referenced Oct 27, 2021
This was referenced Oct 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request details
List of related issues or pull requests
Refs:
Describe the changes made in this pull request
Simplify validation implementation.
Instructions to review the pull request
See preview of the PR here: https://deploy-preview-307--cffinit.netlify.app/#/