Vehicles Persisting After Server-Side Deletion

[Tynopia]

Problem

I'm facing an issue in FiveM related to the Entity Owner and the deletion of entities. Even though I clearly remove vehicles on the server-side and the DoesEntityExist function reports that they no longer exist, these vehicles persist and do not get deleted. The vehicles are spawned in a different routing bucket (where the entity lockdown is set to "inactive").

Server-Side Script

Here is my server-side script in TypeScript, which sets the routing bucket and removes previous vehicles:

onNet("tynopia:garage:server:enter", async (floor: number = 1) => {
    const source = global.source;
    const sourceString = source.toString();
    
    // ...

    if (playerPedId) {
        const bucket = routingBucket + source;

        for (const vehicle of GetAllVehicles()) {
            let count = 0

            if (GetEntityRoutingBucket(vehicle) === bucket) {
                do {
                    DeleteEntity(vehicle);
                    await Delay(50);
                    console.log("Try Delete: " + count++)
                } while (DoesEntityExist(vehicle))
            }
        }

        // ...

        SetPlayerRoutingBucket(sourceString, bucket);
        SetRoutingBucketPopulationEnabled(bucket, false);
        SetRoutingBucketEntityLockdownMode(bucket, "inactive");

        // ...
    }
})

export function exitGarage(source: string, playerPedId?: number, coords?: Vector3): void {
    SetPlayerRoutingBucket(source, 0);
    // ...
}

Client-Side Code

This is my client-side code where I create the vehicle:

// ...
await requestModel(model);
const entity = CreateVehicle(model, coords[0], coords[1], coords[2], coords[3], true, true);
await delayEntityExist(entity);
SetModelAsNoLongerNeeded(model);
// ...

export async function requestModel(model: number | string) {
    RequestModel(model)

    while (!HasModelLoaded(model)) {
        await Delay(50);
    }
}

export async function delayEntityExist(entity: number): Promise<void> {
    while (!DoesEntityExist(entity)) {
        await Delay(50);
    }
}

Issue Video

2023-10-29.02-53-12.mp4

2023-10-29.02-54-15.mp4

2023-10-29.11-22-28.mp4

Unbenannt.mp4

Expected Behavior

When I delete vehicles on the server-side, they should be removed entirely, and there should be no old vehicles persisting when new vehicles are spawned in a different routing bucket.

Actual Behavior

Old vehicles persist and do not get deleted even when the server-side logic indicates that they have been removed and DoesEntityExist reports that they no longer exist.

[Tynopia]

Update

If you make a wait of 250 between each vehicle you spawn, these errors decrease. From 500 it occurs very rarely, but then requires extremely long loading times for a player.

[capncark]

After adding a wait between spawns of up to 2000 the behavior still persists for me. Spawning a group of 10 vehicles in a parking lot only 5 - 7 of the vehicles are removed when calling DeleteEntity on all of them. I tried a 1000 wait between deletes as well. Still no luck. Same behavior on vehicles spawned client and server side.

[Tynopia]

After adding a wait between spawns of up to 2000 the behavior still persists for me. Spawning a group of 10 vehicles in a parking lot only 5 - 7 of the vehicles are removed when calling DeleteEntity on all of them. I tried a 1000 wait between deletes as well. Still no luck. Same behavior on vehicles spawned client and server side.

Do you use a RoutingBucket for the Vehicles?

[capncark]

I did not. I don't know much about routing buckets yet(haven't been coding very long) but I'm reading up on them now to try and get a grasp on it and figure this out. Thanks for the quick reply!

[Tynopia]

I did not. I don't know much about routing buckets yet(haven't been coding very long) but I'm reading up on them now to try and get a grasp on it and figure this out. Thanks for the quick reply!

That's interesting! I thought it was only with RoutingBuckets, but this is significant.
I'm glad to hear that you're new to programming!

[capncark]

Thanks. The strange thing is there seems to be no rhyme or reason as to which vehicles cooperate. It happens on streamed vehicles as well as in-game vehicles including DLC's. Not even a noticeable pattern with specific models. Definitely strange.

[imsnaily]

This gotta be an actual issue of your code because I did something similar and I had no issues with it.

[Tynopia]

This gotta be an actual issue of your code because I did something similar and I had no issues with it.

Hmm okay can you put the code here that we can look at there differences?

[imsnaily]

Was months ago, don't got it anymore.

[Tynopia]

We condensed the script to a smaller resource, containing only the essential elements needed to replicate the issue.

Initially, we identified the issue within the JS script and assumed it might be specific to JavaScript. To investigate further, we tested it in LUA and encountered the same problem. This led us to consider the possibility of an issue related to the IPL where the vehicles spawn.

Unfortunately, the problem persists (you may also test it in the LUA file).

It appears that there might be an issue with Statebags and Entity Owned Vehicles, potentially due to a limit on Owned Vehicles.

issue.zip

[gottfriedleibniz]

Thank you for the reproduction. I'll eventually look into this one (although, if somebody else wants to debug this in the meantime... I won't complain).

[tens0rfl0w]

@gottfriedleibniz My (now deleted) previous comment was a little bit inaccurate. Trying to further deduce the mentioned issue produced this (smaller) repro.

Things to note:

• Executing command spawntest multiple times shows no networked creation failures.
• Executing command bucket 999 (Setting the player's routing bucket to 999) and then executing spawntest shows multiple creation failures.
• Executing spawntest a second time then shows no networked creation failures again (or at least a reduced amount of failures). The worst I saw was some failures on the second run, but the third run went through without any issues again then.

The issue seems to stem from failed networked vehicle creations when a player's routing bucket was recently changed. Checking for clone packets on the server side shows that they either get dropped quite early (before parsing) or the client doesn't send them at all (which is likely the case here).

Some additional findings:
Calling

local try = 1
while not NetworkGetEntityIsNetworked(vehicle) do
    NetworkRegisterEntityAsNetworked(vehicle)
    print('Try: ' .. try)
    try = try + 1
    Wait(0)
end

after each vehicle creation seems to fix the mentioned issue and correctly registers vehicles as networked, even if networking on init creation fails. (If initial registration fails 6-7 'runs'/ticks are needed to correctly register the vehicle as networked.)
As NetworkRegisterEntityAsNetworked does the same calls like CreateVehicle with isNetwork = true and CanRegisterMissionVehicles(1) also returns false if registration fails, this either means we have no free object IDs left or we're owning too many objects. (Normally such 'failed' vehicles would be destroyed by game code, but as vehicles created by scripts have POPTYPE_MISSION as default, this fails silently here.)