[Bug] start and ensure are mixed up

[xalva98]

Summary

If any ressource fails inside of a category getting started, none of the ressource in that category start.

Issue type

Both / Unsure

Repro rate

Always

Server build version

fx: b94-ea/Win

OS

No response

CPU

No response

GPU

No response

RAM

No response

Storage type

None

Connection type

None

ISP and bandwidth

No response

DxDiag

No response

Network graph

No response

Platform

None

OS version / distribution

No response

CPU

No response

RAM

No response

Using txAdmin?

None

Hosting provider

None

Machine type

None

/perf endpoint output

No response

DDoS protection

No response

ulimit -n value (Linux only)

No response

Docker Compose file (Docker only)

No response

Steps to Reproduce

1. create a category, for example [scripts] and insert 100+ ressources
2. start that category (use start, not ensure)

Expected Behavior

The category should start each ressource like it does here (loop through all ressources in that category and start them in alphabetical order)

https://github.com/citizenfx/fivem/blob/25c937b1451be564e66afabab09b47a30d095385/code/components/citizen-server-impl/src/ServerResources.cpp#L673-L707
https://github.com/citizenfx/fivem/blob/25c937b1451be564e66afabab09b47a30d095385/code/components/citizen-server-impl/src/ServerResourceList.cpp#L333-L345

Actual Behavior

Nothing happens, no ressource is started, it seems like the operation is aborted.

Evidence

No response

Additional Context

No response

[xalva98]

After further testing it looks like
ensure and start got swapped.
ensure in legacy should bail out of the loop while start should not

start [category] — plain loop, never bails:
https://github.com/citizenfx/fivem/blob/25c937b1451be564e66afabab09b47a30d095385/code/components/citizen-server-impl/src/ServerResources.cpp#L680-L689

ensure [category] — bails out of the loop on failure:
https://github.com/citizenfx/fivem/blob/25c937b1451be564e66afabab09b47a30d095385/code/components/citizen-server-impl/src/ServerResources.cpp#L814-L826

(doEnsure returns false when the resource can't be found — https://github.com/citizenfx/fivem/blob/25c937b1451be564e66afabab09b47a30d095385/code/components/citizen-server-impl/src/ServerResources.cpp#L785-L793)

[wolfram-cfx]

Thanks, we are looking into this.

[Gogsi]

A fix for this bug has been implemented and is available in the latest patch b96/97. Please try again and let us know if the issue persists. Thanks for your help!

[xalva98]

Confirmed fixed