[Bug] .NET: FromSourceAttribute issues

[matthias18771]

Summary

When using [FromSource] on the playerConnecting event, it cannot resolve to a player object. This is because the PlayerPool only registers a player on the playerJoining event, which happens after playerConnecting has successfully passed.

This is the error:

Invalid arguments specified to event handler for 'playerConnecting':
Handler: Redacted.Server.Server.OnPlayerConnecting, Source: 'internal-net:1', Args: ["matthias",[11,"MjY="],{"defer":[11,"MjE="],"update":[11,"MjI="],"handover":[11,"MjU="],"presentCard":[11,"MjM="],"done":[11,"MjQ="]}]
Error: Source player is required for this handler, since parameter 'sourcePlayer' (index 0) is not nullable

Issue type

Server

Repro rate

Always

Server build version

FXServer-early-access b92 win32

OS

No response

CPU

No response

GPU

No response

RAM

No response

Storage type

None

Connection type

None

ISP and bandwidth

No response

DxDiag

No response

Network graph

No response

Platform

None

OS version / distribution

Windows 11 25H2

CPU

Ryzen 9 9950X3D

RAM

48GB DDR5

Using txAdmin?

Yes

Hosting provider

Self-hosted

Machine type

Dedicated

/perf endpoint output

No response

DDoS protection

No response

ulimit -n value (Linux only)

No response

Docker Compose file (Docker only)

No response

Steps to Reproduce

1. Use this code in a server C# resource:

public void OnPlayerConnecting([FromSource] Player sourcePlayer, string playerName, Action<string> setKickReason, IDictionary<string, Action<object>> deferrals)
{
    deferrals["done"]($"Hello {sourcePlayer.Name}");
}

2. Observe the error in the server console.

Expected Behavior

I expect to have a player object

Actual Behavior

This error:

Invalid arguments specified to event handler for 'playerConnecting':
Handler: Redacted.Server.Server.OnPlayerConnecting, Source: 'internal-net:1', Args: ["matthias",[11,"MjY="],{"defer":[11,"MjE="],"update":[11,"MjI="],"handover":[11,"MjU="],"presentCard":[11,"MjM="],"done":[11,"MjQ="]}]
Error: Source player is required for this handler, since parameter 'sourcePlayer' (index 0) is not nullable

Evidence

No response

Additional Context

No response

[matthias18771]

I looked a bit closer at this issue and the problem seems to be that the player is only registered on playerJoining, not playerConnecting inside CitizenFX.FiveM.Server.Pool.PlayerPool - would explain why it's not available in the playerConnecting handler, since that comes before playerJoining.

Not sure if this intended behaviour or not.

[matthias18771]

I've updated the original discussion from my previous suspicion.

[europium-cfx]

Thanks, we're looking into that

[Gogsi]

A fix for this bug has been implemented and is available in the latest patch b96/97. Please try again and let us know if the issue persists. Thanks for your help!

[dBozee]

Can confirm the issue is still present. #280 shows the same issue on playerDropped and I can confirm that also throws.