[Bug] No retry on ENET handshake failing #82
Replies: 3 comments 3 replies
|
Hello, the ENET handshake is a reliable UDP packet, so it should retry. Are you sure it never does? |
Yes I'm sure. If ENET exits, the FiveM client does not retry to make a new ENET connection like it used to do in the old client, instead it timesout if the first attempt fails. |
|
Can you send your fivem-enhanced.*.log file when this happened? |
|
@wolfram-cfx Please see the attached log from the latest available client version. If ENET state goes from CONNECTING to VERIFY_CONNECT, but then the handshake fails due to underlay reasons (packetloss ,etc) and gets reset, the client does not step back into CONNECTING (the old client would do that attempt 1,2,3 stuff). |
|
ENET indeed seems to stop retrying after a handshake failure. Even minor packet loss during the handshake can reset the connection, but it doesn’t fall back and start a new attempt afterwards. @wolfram-cfx |
|
A fix for this bug has been implemented and is available in the August 4 patch. Please try again and let us know if the issue persists. Thanks for your help! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summary
When the ENET handshake fails, the Enhanced FiveM client gives up after a single attempt and fails with "Connection lost. Timeout: false", instead of retrying the connection. The "normal" FiveM client does retry in this situation.
This is a concern because transient packet loss or network changes can break connections that would otherwise succeed, the client should attempt to self-heal by retrying the handshake.
Additionally, handshake retries would enable better (asymmetric) DDoS protection.
Issue type
Client
Repro rate
Always
Server build version
FXServer-early-access b92 win32
OS
Windows 11
CPU
AMD Ryzen 9800X3D
GPU
No response
RAM
No response
Storage type
None
Connection type
None
ISP and bandwidth
No response
DxDiag
No response
Network graph
No response
Platform
Windows
OS version / distribution
No response
CPU
No response
RAM
No response
Using txAdmin?
Yes
Hosting provider
Self-hosted
Machine type
VPS
/perf endpoint output
No response
DDoS protection
Yes
ulimit -n value (Linux only)
No response
Docker Compose file (Docker only)
No response
Steps to Reproduce
Fail/reset connection during ENET handshake
Expected Behavior
Client should retry the handshake
Actual Behavior
Client connection fails with error message
"Connection lost. Timeout:flalse"Evidence
No response
Additional Context
No response
All reactions