Conversation
hanefi
commented
Apr 6, 2020
| - name: trigger-dockerhub | ||
| if: branch = master AND type != pull_request | ||
| env: | ||
| - DOCKERFILE=Dockerfile |
Member
Author
There was a problem hiding this comment.
Why I removed the env fields here:
- The
trigger-dockerhubstage should happen only once, not 3 times - It is not so easy to provide name fields, when we have a matrix (If name field is provided they significantly improve CI interface)
hanefi
commented
Apr 6, 2020
| stages: | ||
| - build-image | ||
| - name: trigger-dockerhub | ||
| if: branch = master AND type != pull_request |
Member
Author
There was a problem hiding this comment.
CI docs state that branch variable stores current branch name; However for pull requests: the base branch name.
We should trigger builds only in two cases:
- A PR gets merged into master
- A Cron Job triggers the CI build on master
onlined
approved these changes
Apr 6, 2020
JelteF
approved these changes
Apr 6, 2020
Contributor
JelteF
left a comment
There was a problem hiding this comment.
LGTM, assuming you did some testing of this.
Member
Author
Yes, I did. I monitored recent builds on docker hub, and observed that we can build new images there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have several rules on Docker Hub that gets triggered on branch and tag pushes. However we do not have a mechanism to update images nightly. This PR aims to do the following:
Proposed CI workflow:
latest,alpineandnightlyimages