Skip to content

Introduce DockerHub build trigger #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanefi merged 2 commits into from
Apr 6, 2020
Merged

Introduce DockerHub build trigger #183

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a96a822
Introduce DockerHub build trigger
hanefi Apr 6, 2020
3343f9c
Disable DockerHub triggers on PRs
hanefi Apr 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,23 @@
sudo: required
services: [ docker ]
stages:
- build-image
- name: trigger-dockerhub
if: branch = master AND type != pull_request
Copy link
Copy Markdown
Member Author

@hanefi hanefi Apr 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI docs state that branch variable stores current branch name; However for pull requests: the base branch name.

We should trigger builds only in two cases:

  1. A PR gets merged into master
  2. A Cron Job triggers the CI build on master

env:
- DOCKERFILE=Dockerfile
Copy link
Copy Markdown
Member Author

@hanefi hanefi Apr 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why I removed the env fields here:

  1. The trigger-dockerhub stage should happen only once, not 3 times
  2. It is not so easy to provide name fields, when we have a matrix (If name field is provided they significantly improve CI interface)

- DOCKERFILE=Dockerfile-alpine
global:
secure: ltHu30nhJVVl5QhdBk1jaf45V6TO9S+JhxAqVgDAxItyJu3PzoNWa2M9ocxP2axONHfEFhekjGrch09SYjChmr5lwPr/58vQHc1RR8plRR77mIrySGDIF3L0fxHmecCcx3uzEQhYmrEMoToo3WVAViNVYB2R3i/8Kp4pgKQUZza+C5RgLaymHntaebyuW3PSKi3ReDjQdU6KH/Xv2p9jBtVs7XCjSPs7BYvvm8miHlo2GwynB+iIpqksvrBG3C7A9FSaOSaggyx6d3eKQKPNUbj8bakDJuuGgAVs1RHSRyjS6MzvdFgLgvr8/Mve4X840Dt5YfI9pAIIm37KY+/ZduisGUrqIPsD0agJ8BZjmDMFLdAfbY3G2vcoRS+7UnJoSSVDxqtPFbsdqKKz2n4a3XbZHPNmGAZeunncfXz/332hlj9qapYKP+PN3ZS3aCpJgG2V8+uyhfboDKCfQk3/TKhoNDg/BrNZdLTSZT8HCmExerG98l2OFcjX/4Zi/Q6fGBf7TbERCGdBpYqx4CWSPO2OpQ7IP0mLOWWNiVeHzhj0w1ELmJPgFWNdROxGIdjN/YyMyjrXe/NF9zvqbUcH4X419W69vLyFB7+hdXkGYJ4E8BiG7Kc7O7JOugMgzQ6kJ+7AtmaQDZnq1ZUACQ5BTS+68PUqKRZYCdcXqxi7Y0M=
script:
- docker build -f "$DOCKERFILE" -t citusdata/citus:9.2.4 .
jobs:
include:
- stage: build-image
name: "latest"
script: docker build -f Dockerfile .
- stage: build-image
name: "alpine"
script: docker build -f Dockerfile-alpine .
- stage: build-image
name: "nightly"
script: docker build -f nightly/Dockerfile .
- stage: trigger-dockerhub
name: "Trigger DockerHub Builds"
script: curl -X POST "$DOCKERHUB_BUILD_TRIGGER"