Skip to content

Bump pgautofailover all version to 1.3.1#469

Merged
JelteF merged 4 commits intoall-pgautofailoverfrom
all-pgautofailover-push-1588761831
May 7, 2020
Merged

Bump pgautofailover all version to 1.3.1#469
JelteF merged 4 commits intoall-pgautofailoverfrom
all-pgautofailover-push-1588761831

Conversation

@JelteF
Copy link
Copy Markdown
Contributor

@JelteF JelteF commented May 6, 2020

No description provided.

Comment thread debian/changelog Outdated
Comment thread pg-auto-failover.spec Outdated
@JelteF JelteF force-pushed the all-pgautofailover-push-1588761831 branch from 144af69 to 5006dde Compare May 7, 2020 09:10
@JelteF JelteF changed the title Bump pgautofailover all version to 1.3 Bump pgautofailover all version to 1.3.1 May 7, 2020
@JelteF JelteF requested a review from hanefi May 7, 2020 09:36
@JelteF JelteF force-pushed the all-pgautofailover-push-1588761831 branch from 5006dde to 4abb4ce Compare May 7, 2020 09:40
Comment thread debian/changelog Outdated
Comment thread pg-auto-failover.spec Outdated
@JelteF JelteF force-pushed the all-pgautofailover-push-1588761831 branch 2 times, most recently from a56e876 to 2100c50 Compare May 7, 2020 13:00
@JelteF JelteF force-pushed the all-pgautofailover-push-1588761831 branch from 2100c50 to c86e467 Compare May 7, 2020 13:02
Copy link
Copy Markdown
Member

@hanefi hanefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After 2 simple changes in changelog items for consistency between all sections, we can merge this

Comment thread pg-auto-failover.spec

%changelog
* Thu May 7 2020 - Jelte Fennema <Jelte.Fennema@microsoft.com> 1.3.1-1
- Official 1.3.1 release of pg_auto_failover
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have wanted to see a consistent item in here such as:

  - Official release for 1.3.1

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better with the name of the tool in there too.
I've modified update_os_package.pl to do this automatically for new versions:
https://github.com/citusdata/tools/pull/69/files#diff-99ba4ed771cad68c7bae27b53c0c4aa3R91

Comment thread debian/changelog
@JelteF JelteF merged commit aa570d4 into all-pgautofailover May 7, 2020
@JelteF JelteF deleted the all-pgautofailover-push-1588761831 branch May 7, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants