Skip to content

Update error handling in handlers and functions #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
whoabuddy merged 3 commits into from
May 12, 2022
Merged

Update error handling in handlers and functions #62

whoabuddy merged 3 commits into from
May 12, 2022

Conversation

@whoabuddy
Copy link
Contributor

@whoabuddy whoabuddy commented May 12, 2022

This PR implements a generic structure per handler where:

  • variables used are defined/typed at the top
  • inputs are checked (undefined = 400 response)
  • try to get/calculate values (null = 404 response)
  • catch errors and report as 404 response
  • return response in correct format

Tracking:

whoabuddy added 3 commits May 12, 2022 07:57
@whoabuddy
fix: update getUserId to validate stacks address
0788048
@whoabuddy
fix: validate stacks addresses when submitted
a8127ba
@whoabuddy
fix: update all remaining error handling
a2d0f39 
This consolidates a lot of the function calls into a single try/catch statement, where errors from upstream functions can be returned as a 404 Response.

In addition each endpoint follows a simple three part structure: check inputs, get/calculate data, return response
@whoabuddy whoabuddy merged commit 276a3aa into develop May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Review endpoint error handling Bug: Get User ID API returns not intended status code Bug: Exception if contract principal is passed

2 participants

@whoabuddy