fix(oauth): form-urlencode the token refresh (was JSON → /token 400s) - #5
Merged
Conversation
Refresh() POSTed a JSON body with Content-Type: application/json to /api/auth/oauth/token, but that endpoint is the @node-oauth/oauth2-server token handler, which REQUIRES application/x-www-form-urlencoded and rejects JSON with "content must be application/x-www-form-urlencoded". The custom device-flow endpoints (/device, /device-token) accept JSON, so LOGIN worked — but every refresh failed, so OAuth auth silently died after the 1h access-token TTL (observed live: `whoami` → "device login failed: ... must be application/x-www-form-urlencoded"). Fix: add postForm() (x-www-form-urlencoded) and send the refresh grant through it. Verified live: an expired session refreshes cleanly against prod. The bug slipped #4's tests because TestRefreshRotatesToken's mock decoded the request body as JSON (accepting the wrong content-type). Hardened it to assert Content-Type: application/x-www-form-urlencoded + ParseForm — it now FAILS on a JSON refresh and PASSES on the form-encoded one. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refresh() POSTed a JSON body with Content-Type: application/json to
/api/auth/oauth/token, but that endpoint is the @node-oauth/oauth2-server token
handler, which REQUIRES application/x-www-form-urlencoded and rejects JSON with
"content must be application/x-www-form-urlencoded". The custom device-flow
endpoints (/device, /device-token) accept JSON, so LOGIN worked — but every
refresh failed, so OAuth auth silently died after the 1h access-token TTL
(observed live:
whoami→ "device login failed: ... must beapplication/x-www-form-urlencoded").
Fix: add postForm() (x-www-form-urlencoded) and send the refresh grant through
it. Verified live: an expired session refreshes cleanly against prod.
The bug slipped #4's tests because TestRefreshRotatesToken's mock decoded the
request body as JSON (accepting the wrong content-type). Hardened it to assert
Content-Type: application/x-www-form-urlencoded + ParseForm — it now FAILS on a
JSON refresh and PASSES on the form-encoded one.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com