fix: remove hardcoded nyc1 region from marketplace app queries#582
Merged
dippydocus merged 2 commits intomasterfrom Apr 14, 2026
Merged
fix: remove hardcoded nyc1 region from marketplace app queries#582dippydocus merged 2 commits intomasterfrom
dippydocus merged 2 commits intomasterfrom
Conversation
CheckAPPName() and ListDefaultApps() hardcoded client.Region to nyc1, which breaks any environment where nyc1 doesn't exist (e.g. staging). config.CivoAPIClient() already sets the region from the user's config, so the override is unnecessary.
giornetta
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckAPPName()andListDefaultApps()inutility/check.gohardcodedclient.Region = "nyc1", which breaks any environment wherenyc1doesn't exist (e.g. staging)config.CivoAPIClient()already sets the region from the user's config (Current.Meta.DefaultRegion), so the override is unnecessaryIntroduced in 8cb7cea (#529).
Test plan
go build ./...compiles cleancivo k3s createagainst staging API — no longer returnsdatabase_region_not_foundcivo k3s createstill works against production (nyc1 exists, so behavior is unchanged)civo k3s create --applications=traefik2-nodeportvalidates app names correctly