Merged
Conversation
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
jokestax
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR include FakeClient, a test client designed for more flexible behavior control when civogo.FakeClient alone is not sufficient.
Changes
Added FakeClient, which embeds civogo.FakeClient and allows overriding HardRebootInstance via a function.
Ensured FakeClient satisfies the civogo.Clienter interface at compile time.
Motivation
The standard civogo.FakeClient may not always provide the required level of flexibility in testing. FakeClient enables customized behavior by allowing function injection for HardRebootInstance, making it easier to control test scenarios. By injecting behavior from the outside, we can perform more flexible and controlled tests.