Add configurable reboot threshold time and skip reboot if status recently updated#13
Merged
Add configurable reboot threshold time and skip reboot if status recently updated#13
Conversation
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
jokestax
reviewed
Mar 4, 2025
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
jokestax
approved these changes
Mar 4, 2025
Member
Author
|
@jokestax Thank you for your review 🙏 I will merge this PR 🚀 cc: @johndietz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the current implementation, we encountered an issue where reboots were happening at a high frequency. In response to this, we received a request from the user to specify a time window of "about 40 minutes," and the implementation was modified to meet this requirement.
In this PR's implementation, when the check loop starts, it executes a reboot if there has been no status update within the default time window of -40 minutes. To address the issue caused by the previous behavior, we introduced a configurable time window to prevent unnecessary reboots.
The node judgment logic remains the same as before with two cases.
When these cases are met, the node status update time is checked, and if the invalid status persists for a period of -40 minutes (which can be adjusted using environment variable), a reboot is triggered. This change is expected to resolve the issue of frequent reboots.