Skip to content

History

Revisions

  • API: enumerate as a table — change, public, class, per-row verdict

    @cixzhang cixzhang committed Aug 24, 2026
    8f65f0d
  • SOLUTION: a holistic design pass is one decision; behaviour and new API still split out

    @cixzhang cixzhang committed Aug 24, 2026
    415d415
  • JUDGEMENT: four verdicts in priority order — comment only when problem/solution/impact are unclear

    @cixzhang cixzhang committed Aug 24, 2026
    08f3d9d
  • put the VERDICT line in every slot of the output template, not just the convention note

    @cixzhang cixzhang committed Aug 24, 2026
    8cf0848
  • PERFORMANCE: the evidence a perf block must carry — counts not clocks, both builds one run, multiple N, banked repro

    @cixzhang cixzhang committed Aug 24, 2026
    d972794
  • every slot ends in a VERDICT line; JUDGEMENT curates them instead of re-deriving

    @cixzhang cixzhang committed Aug 24, 2026
    85a3a97
  • PERFORMANCE: a measured degradation is request-changes, not a tradeoff note

    @cixzhang cixzhang committed Aug 24, 2026
    119c623
  • A11Y & I18N is its own slot, wired to rubric section 1 and section 9

    @cixzhang cixzhang committed Aug 24, 2026
    0bcd107
  • VISUAL EVIDENCE: label every difference intentional or not; intentional cites the PR's problem, Design Conventions or rubric §5

    @cixzhang cixzhang committed Aug 24, 2026
    ed0846d
  • ossification: a new concept is marked [Needs human judgement], not argued

    @cixzhang cixzhang committed Aug 24, 2026
    53c03c0
  • ossification: ask who else has this problem and what they called it

    @cixzhang cixzhang committed Aug 24, 2026
    6b8895c
  • scatter the audit rubric across the template: §3 in API, §2 in THEMING, §1+§9 rendered in VISUAL EVIDENCE, §4+§9 source in BREAKING

    @cixzhang cixzhang committed Aug 24, 2026
    9c484eb
  • API absorbs ossification — answered per enumerated line, not per PR

    @cixzhang cixzhang committed Aug 24, 2026
    d76c056
  • JUDGEMENT: name which half needs a human — design owner stands in for design, never for API

    @cixzhang cixzhang committed Aug 24, 2026
    cfeaf7e
  • STEP 5b: grep the siblings before writing a convention finding; R31: merge prose is not a trailer; R32: green CI is not evidence CI ran

    @cixzhang cixzhang committed Aug 24, 2026
    107d8f9
  • R33: 'do we want this at all' is a human step — capability PRs never merge unattended

    @cixzhang cixzhang committed Aug 24, 2026
    03ebb81
  • R32: verify the class, not the case — from the #5321/#5214/#5110 retractions

    @cixzhang cixzhang committed Aug 24, 2026
    1ce4a53
  • R31: merge reads a trailer not prose; R31b: reconcile with our own open review; R31c: check main did not invalidate the PR

    @cixzhang cixzhang committed Aug 24, 2026
    e57345f
  • R3l-cite: cite the rule and its sentence, not the page name

    @cixzhang cixzhang committed Aug 24, 2026
    e75b1ec
  • R3l: design/API judgement calls have wiki pages; BREAKING gains behaviour, PERFORMANCE gains effects, THEME TARGETS renamed THEMING

    @cixzhang cixzhang committed Aug 24, 2026
    dbd21ae
  • Review-5420: request-changes posted; contrast finding, nightly follow-up noted

    @cixzhang cixzhang committed Aug 24, 2026
    a063619
  • Review-5418: request-changes posted; verdict moved twice, nightly follow-up noted

    @cixzhang cixzhang committed Aug 24, 2026
    33c7485
  • Review-5434: visual-gate clock freeze — approve, merged by the loop

    @cixzhang cixzhang committed Aug 24, 2026
    c51fdbe
  • Review-5426: approve + merged; set-level findings for the #5417 theme-target rows

    @cixzhang cixzhang committed Aug 24, 2026
    60c57d1
  • Record 2026-08-24 incoming run: 5321, 5394, 5414, 5419

    @cixzhang cixzhang committed Aug 24, 2026
    66523be
  • R17: gate 3 clean on #5385 and #5428; correct the render-prop count to its enumeration

    @cixzhang cixzhang committed Aug 24, 2026
    2307b15
  • R17: record reviews for #5385 (minQueryLength) and #5428 (renderToast), both drafted not posted

    @cixzhang cixzhang committed Aug 24, 2026
    6cc2f66
  • Review-5353: round two — request-changes, and the critic overturning the reviewer

    @cixzhang cixzhang committed Aug 24, 2026
    c2aad4b
  • Point the derived-gate note back at #5421

    @cixzhang cixzhang committed Aug 24, 2026
    da8ecfe
  • Point the derived-gate note at its knot, not the closed GitHub issue

    @cixzhang cixzhang committed Aug 24, 2026
    76a4957