Merged
Conversation
atsushieno
force-pushed
the
msvc-build-fix
branch
from
0037162 to
b6b31b9
Compare
Contributor
Author
nevermind, it's reported as build failure so I could fix the changes. |
Owner
|
Thanks for the contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to use rtlog-cpp on Windows sing VC++, but it does not like GCC extension attributes. If I understand correctly,
formatdoes not affect run-time behavior, so I simply took it out for VC++.(I'm not sure how clang-format likes this change, on CLion it does not auto format like current code file. I leave it as is. Excuse me of that.)