Complete digital signature signing + verification (7/7 pass) - #17
Merged
Conversation
Signing: - Create signature dict with ByteRange and Contents placeholder - Insert Contents hex string directly into serialized PDF bytes - Compute ByteRange with size-adjustment for variable-length values - Create OpenSSL PKCS#7 detached signature over signed byte range - Inject hex-encoded signature into Contents placeholder Verification: - Parse signed PDF bytes for /ByteRange and /Contents - Extract signed data using ByteRange offsets - Parse PKCS#7 DER from hex-encoded Contents - Verify signature against trusted certificates via OpenSSL - Return Result structs with signer, valid?, cert_chain - Return empty array for unsigned documents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full PKCS#7 detached signing with ByteRange computation