v1.1rc #11
v1.1rc #11
Conversation
they are basically just duplicate info anyways
to compare adoption between schools
| ### iOS | ||
|
|
||
| 1. Navigate to https://classclock.app in Safari (not tested on other browsers) | ||
| 1. Navigate to ClassClock in Safari (not tested on other browsers) |
There was a problem hiding this comment.
We should include a link, in case people don't know the URL.
There was a problem hiding this comment.
its in the github description thingy. im thinking this part of the README will eventually be moved to like a support page or guides page or something on the classclock website
| var currentHours = 0; | ||
| var currentMinutes = 0; | ||
| var currentSeconds = 0; | ||
| let DAY_OFF_FLAG = "day off" |
There was a problem hiding this comment.
I'd recommend putting the flags into an object/enum to really drive home the fact that they're flags (vs. constant variables/strings). This way, anytime you reference a flag it would show as ScheduleFlags.DAY_OFF_FLAG.
There was a problem hiding this comment.
yeah that sounds good. one of us can add it when we have time
There was a problem hiding this comment.
this has been done (i think) in the react version
|
Oh, and one more thing. Since this project is starting to get pretty big, do you want to start moving over to TypeScript? From personal experience - it helps in larger projects. |
|
would Typescript break compatibility with any browsers or introduce bulky dependencies? |
|
because i messed up and prematurely tagged c178194 as v1.0 (has been fixed now), I am closing this and am going to resubmit this PR on a |
No description provided.