Skip to content

v0.2rc #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 51 commits into from
Mar 31, 2019
Merged

v0.2rc #13

merged 51 commits into from
Mar 31, 2019

Conversation

@MoralCode
Copy link
Member

@MoralCode MoralCode commented Mar 21, 2019 •
edited
Loading

This is the same PR content as #11 except:

  • fixed a bug where times between noon and 1PM show are presented as AM and not PM
  • the branch name now reflects the pre-release nature of this update
  • I have added proper social media buttons to the settings page instead of the text-based hyperlinks

Overall, merging this pull request will:

  • apply some fairly significant changes to the backend, most notably some refactoring and using time states to simplify things
  • start using matomo tag manager for visit tracking instead of the traditional method
  • move the "view schedule" button to be located underneath the "you are viewing the ___ Schedule"
  • add the school name to the app's main screen and schedule page
  • add social media buttons on the settings page
  • add flash messages (although the implementation may need to change later)
  • fixed a bug where times between noon and 1PM show are presented as AM and not PM

@MoralCode
remove extraneous </html>
d3d722b
@MoralCode
add schoolIsInSession() function
c21b292
@MoralCode
add state flags
f168fb6
@MoralCode
remove passing periods from the schedule
426c81b 
they are basically just duplicate info anyways
@MoralCode
re-organise updateText using state flags
76a8b68
@MoralCode
continue to update the time even if schedule data is not available
a0af5a6
@MoralCode
Add flash function
bd0c146
@MoralCode
Change data structure to support multiple hardcoded schools
53d8eea
@MoralCode
add function to get an index from localStorage
4a608cf
@MoralCode
Add School Name
437b16d
@MoralCode
fix close spacing on settings page
d775a8b
@MoralCode
continue to update date and time even if a school isn't selected
5fde3c6
@MoralCode
move nav button HTML to a more sensible place
516b99e
@MoralCode
group elements that are schedule-based together for easier hiding
2249dd7
@MoralCode
hide schedule-based elements when there is no schedule selected
e8fec35
@MoralCode
move flash messages above the whole page rather than over the top of it
cfac59c
@MoralCode
Documentation and cleanup
e037d9e
@MoralCode
fix flashing so that the layouts dont break on mobile
cc3af4a
@MoralCode
add school name to summary for clarity
12eedae
@MoralCode
add slack link instead of github issues link
5fcc0fa
@MoralCode
Add a tracking metric for the school someone has selected
5c2188c 
to compare adoption between schools
@MoralCode
Move "View Schedule" link
9cae0b8
@MoralCode
re-configure display of school name on homepage
5cfa996
@MoralCode
fix flash messages taking up half the screen sometimes
359ff24
@MoralCode
add tracking for usage of time display setting
a7eb69c
@MoralCode
refactor getClassName()
96eadf6
@MoralCode
replace time globals with a method to get the current time object
d3a8978
@MoralCode
add proper time comparison methods
8a7fdbf
@MoralCode
implement new time methods
7ad2861
@MoralCode
fix centered links extending all the way across the page
8bfd994
@MoralCode
fix missing "...which ends in:" data on main page
c1d7049
@MoralCode
refactor compareTimes() to include minutes in it's calculation
2c66a1f
@MoralCode
Add sanitizeTimeObject()
2e07244
@MoralCode
add getMostRecentlyStartedClassIndex()
f424879
@MoralCode
make getTimeDelta() more flexible
854c7ea
@MoralCode
samitize times before comparing them so it doesnt skip seconds
d9878b4
@MoralCode
add passing period name to school data
50a3ba1
@MoralCode
add getTimeTo() shortcut
3b358a2
@MoralCode
remove getTimeToEndOfCurrentClassString() and getTimeToStartOfSchoolS…
db6d769 
…tring() methods
@MoralCode
update documentation and comments
ce25c98
@MoralCode
replace tracking code with matomo tag manager
00893bf
@MoralCode
hide labels on no school days
6bfbc2b
@MoralCode
add styles for links in flash messages
6b485dd
@MoralCode
remove links from readme
1f49a7a
@MoralCode
update domain name on dev branch
97e7ab5
@MoralCode
fix an instance of the old name
f611fc0
@MoralCode
Update README file
0ae2bd8
@MoralCode
copy config.yml from landing page
19a7e12
@MoralCode
replace github and slack links with better social media links
df016e4
@MoralCode
Update links to github and social media on settings page
99d1e9f
@MoralCode
Fix bug where noon appears as 12 AM
b13c948
@MoralCode MoralCode merged commit 7161b1e into master Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MoralCode