issue compiling geoclaw executable

[macinneb]

I posted this to the Google Groups, but I think I'm supposed to post the issue here instead.

Our version of gcc is 10.2 and python is 3.8.5

I'm working on setting up new computers for students to use with this version and have hit an error when trying out make .plots for the chile2010 example.

Here is the error:

-I/Users/macinnesb/clawpack-installations/clawpack-v5.7.1/amrclaw/src/2d/ -I/Users/macinnesb/clawpack-installations/clawpack-v5.7.1/geoclaw/src/2d/shallow/ -I/Users/macinnesb/clawpack-installations/clawpack-v5.7.1/geoclaw/src/2d/shallow/multilayer/ -I/Users/macinnesb/clawpack-installations/clawpack-v5.7.1/geoclaw/src/2d/shallow/surge/ -L/Users/macinnesb/clawpack-installations/clawpack-v5.7.1/geoclaw/examples/tsunami/chile2010Trial/ -o /Users/macinnesb/clawpack-installations/clawpack-v5.7.1/geoclaw/src/2d/shallow/filval.o
/Users/macinnesb/clawpack-installations/clawpack-v5.7.1/geoclaw/src/2d/shallow/filval.f90:154:51:

95 | call preintcopy(valc,mic,mjc,nvar,iclo,ichi,jclo,jchi,level-1,fliparray)
| 2
......
154 | jlo-nghost,jhi+nghost,level,1,1,fliparray)
| 1
Error: Type mismatch between actual argument at (1) and actual argument at (2) (INTEGER(4)/REAL(8)).
make: *** [/Users/macinnesb/clawpack-installations/clawpack-v5.7.1/geoclaw/src/2d/shallow/filval.o] Error 1

[mandli]

It appears that the new version of gcc is pickier about this than it has been in the past. @bolliger32 caught this in clawpack/geoclaw#476 and fixed it in clawpack/geoclaw#477. Unfortunately this did not get into 5.7.1 though.

@rjleveque if we start having a bunch of people running the newer version of gcc and run into this we may want to do another release sooner rather than later.

[rjleveque]

Yes, agreed. There are a couple other GeoClaw fixes that should also be tested a bit and merged in,
clawpack/geoclaw#461
clawpack/geoclaw#456
and another not yet in a PR. I will work on this.

[see-on]

I realise I'm very late to this, but I also had this issue, and solved it, so it may work for you if you are still experiencing this problem.

In the directory in which you are running the code, there should be a Makefile.
e.g $CLAW/geoclaw/examples/tsunami/chile2010/Makefile is the path to the Makefile for the example chile2010 simulation.
Open the Makefile with a text editor, and find the phrase:
FFLAGS ?=
and replace it with:
FFLAGS ?= -fallow-argument-mismatch

Now re-run your code, and hopefully your problem is fixed.

[mandli]

That's a good suggestion. We need to start collecting these in a FAQ as there was another argument mismatch I recently found and was added to the release in 5.8.0. Going to add this to things to add to a FAQ though and close this particular issue.