fix issue #4, gem changes behavior of integer division#5
Open
freefrancisco wants to merge 1 commit intoclbustos:masterfrom
Open
fix issue #4, gem changes behavior of integer division#5freefrancisco wants to merge 1 commit intoclbustos:masterfrom
freefrancisco wants to merge 1 commit intoclbustos:masterfrom
Conversation
…ting rid of mathn
Author
There was a problem hiding this comment.
Got this Prime class from mathn.rb in ruby 1.8.7
clbustos
pushed a commit
that referenced
this pull request
Jan 23, 2016
Test on Ruby 2.2 and auto test on patched versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gem only changes behavior of integer division in ruby versions < 1.9, because it includes mathn in order to use Prime. But mathn has the side effect of changing integer division. Instead of including mathn, we can just copy the Prime code from ruby 1.8.7 in the one line where mathn is called.