Guard all incident actions against nil selection#233
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
==========================================
+ Coverage 67.01% 67.73% +0.71%
==========================================
Files 26 26
Lines 3762 3790 +28
==========================================
+ Hits 2521 2567 +46
+ Misses 1108 1088 -20
- Partials 133 135 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clcollins
force-pushed
the
srepd/fix-actions-no-selection
branch
from
da6475f to
e07b7a7
Compare
Actions in both table and incident-view modes now check for a valid selection before executing, returning "no incident selected" or "no incident highlighted" status messages instead of proceeding with nil data or opening empty viewers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
clcollins
force-pushed
the
srepd/fix-actions-no-selection
branch
from
e07b7a7 to
fe643f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added nil-selection guards to 10 action handlers in msgHandlers.go:
Closes #224
🤖 Generated with Claude Code