Fix issues identified by user#138
Merged
Merged
Conversation
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
Collaborator
|
good to see users started giving feedback :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discord user's feedback:
Azure file naming — ebs_snapshots_old.py under the Azure rules uses AWS terminology ("EBS"). The code inside is correct Azure logic, but the filename is misleading.
Wrong provider in error message — The EnvironmentError handler in scan/command.py defaults to suggesting cleancloud doctor --provider azure even when the user is scanning AWS. It only checks for GCP, everything else falls through to Azure.
Heavy install footprint — All three cloud SDKs (AWS, Azure, GCP) are hard dependencies. An Azure-only user has to install boto3 and all the google-cloud packages they'll never use.
No per-call API timeouts — Individual provider API calls like snapshots.list() or describe_endpoint don't have explicit timeouts. If a provider API hangs, the scan can freeze indefinitely even though there's a global --timeout flag.
The first two issues are fixed, 3 and 4 will be fixed in future PRs