Skip to content

Fix issues identified by user #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sureshcsdp merged 1 commit into from
Apr 11, 2026
Merged

Fix issues identified by user #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...roviders/azure/rules/ebs_snapshots_old.py → ...oviders/azure/rules/disk_snapshots_old.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion cleancloud/providers/azure/scan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
from cleancloud.providers.azure.rules.container_registry_unused import (
find_unused_container_registries,
)
from cleancloud.providers.azure.rules.ebs_snapshots_old import find_old_snapshots
from cleancloud.providers.azure.rules.disk_snapshots_old import find_old_snapshots
from cleancloud.providers.azure.rules.lb_no_backends import find_lb_no_backends
from cleancloud.providers.azure.rules.public_ip_unused import find_unused_public_ips
from cleancloud.providers.azure.rules.sql_database_idle import find_idle_sql_databases
Expand Down
5 changes: 1 addition & 4 deletions cleancloud/scan/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,10 +843,7 @@ def scan(
click.echo()
click.echo(f"Authentication failed — {e}")
click.echo()
if provider == "gcp":
click.echo("Run `cleancloud doctor --provider gcp` to diagnose.")
else:
click.echo("Run `cleancloud doctor --provider azure` to diagnose.")
click.echo(f"Run `cleancloud doctor --provider {provider}` to diagnose.")
sys.exit(EXIT_PERMISSION_ERROR)

except botocore.exceptions.NoCredentialsError:
Expand Down
4 changes: 2 additions & 2 deletions ...ers/azure/test_azure_ebs_snapshots_old.py → ...rs/azure/test_azure_disk_snapshots_old.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from datetime import datetime, timedelta, timezone
from types import SimpleNamespace

from cleancloud.providers.azure.rules.ebs_snapshots_old import find_old_snapshots
from cleancloud.providers.azure.rules.disk_snapshots_old import find_old_snapshots


def test_find_old_snapshots(monkeypatch):
Expand Down Expand Up @@ -40,7 +40,7 @@ def __init__(self, credential, subscription_id):
self.snapshots = MockSnapshots()

monkeypatch.setattr(
"cleancloud.providers.azure.rules.ebs_snapshots_old.ComputeManagementClient",
"cleancloud.providers.azure.rules.disk_snapshots_old.ComputeManagementClient",
MockComputeClient,
)

Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/azure/test_azure_rules_smoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from cleancloud.providers.azure.rules.container_registry_unused import (
find_unused_container_registries,
)
from cleancloud.providers.azure.rules.ebs_snapshots_old import find_old_snapshots
from cleancloud.providers.azure.rules.disk_snapshots_old import find_old_snapshots
from cleancloud.providers.azure.rules.lb_no_backends import find_lb_no_backends
from cleancloud.providers.azure.rules.public_ip_unused import find_unused_public_ips
from cleancloud.providers.azure.rules.sql_database_idle import find_idle_sql_databases
Expand Down
Loading