add name to domain api#21
Conversation
| from clearbit.resource import Resource | ||
| from reveal import Reveal | ||
| from risk import Risk | ||
| from name_to_domain import NameToDomain |
There was a problem hiding this comment.
I think remove the underscores
There was a problem hiding this comment.
name_to_domain is the file name — are you running into errors running this or is there a convention I'm not aware of?
There was a problem hiding this comment.
Can you check, but I have a feeling that's the convention.
There was a problem hiding this comment.
I did check before I made the previous comment, but wasn't sure if you knew something I might not haha
There was a problem hiding this comment.
I don't think it's against convention. Looking at PEP-8 and I don't see anything about it https://www.python.org/dev/peps/pep-0008/
| from clearbit.resource import Resource | ||
| from reveal import Reveal | ||
| from risk import Risk | ||
| from name_to_domain import NameToDomain |
There was a problem hiding this comment.
I don't think it's against convention. Looking at PEP-8 and I don't see anything about it https://www.python.org/dev/peps/pep-0008/
3 participants
We're looking at publicly releasing this next week, so I've gone ahead and added support to the Python package 👍