Remove expected diagnostics that sometimes are not present #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hilary-luo
requested review from
civerachb-cpr and
mikehosmar
and removed request for
a team
civerachb-cpr
approved these changes
May 21, 2025
Contributor
civerachb-cpr
left a comment
civerachb-cpr
left a comment
There was a problem hiding this comment.
For ease-of-maintenance, does it make sense to have empty arrays instead of nothing?
expected: []
Contributor
Author
|
I'm leaning towards not because it is being conditionally overwritten in clearpath_generator_common so it should not be set here. I could see value in a comment about that though. |
civerachb-cpr
approved these changes
May 22, 2025
luis-camero
pushed a commit
that referenced
this pull request
May 26, 2025
* Remove expected diagnostics that sometimes are not present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the associated clearpath_common PR for where some of these are re-introduced.