Skip to content

Conversation

@luis-camero
Copy link
Contributor

Initial pass on configuration YAML for review.

</details>

## Platform
Every robot platform has unique structures just as versatile sensor mounting solutions, wireless charging receivers, and waterproofing enclosures; we refer to these as decorations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decorations seems misaligned with other Clearpath branding terms. Brackets seems more aligned with existing Clearpath webpages. Consider reviewing this with someone from Marketing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also use OTTO's glossary of Product / Branding terms:
https://wiki.clearpathrobotics.com/pages/viewpage.action?pageId=106572126

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking a look at the glossary, the closest entry to what a decoration would be is an attachment.

attachment Additional hardware products that are installed on robots to enhance their capabilities. For example lifts, conveyors, and arms. DO NOT USE: Accessory, Appliance

Decorations was used in the ROS 1 Husky code to refer to attachments that were unique to the Husky, such as bumpers, top plates, and sensor archs.

The attachment, as is defined by OTTO, applies to all entities in the config, i.e. decorations, accessories (probably needs changing), mounts, and sensors.

I think that the word decorations has connotations of an ornamental, non-functional item; and, it does not fit the concept of a charging bumper, versatile top plate, or sensor arch. Therefore, it will seem out of place to anyone not familiar with the Husky codebase.

@luis-camero
Copy link
Contributor Author

@rhysfaultless-cpr, @tonybaltovski I've added samples to add all config entities and an example Husky that adds decorations, mounts, and sensors step by step to the config with images.

Copy link
Member

@tonybaltovski tonybaltovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits.

@luis-camero luis-camero merged commit 89d005d into clearpathrobotics:ros2-humble Jul 7, 2023
@luis-camero luis-camero deleted the ros2-humble branch July 7, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants