Skip to content

Conversation

@roni-kreinin
Copy link
Contributor

Also addressing some points in #128

@roni-kreinin roni-kreinin requested a review from hilary-luo July 6, 2023 18:45
@roni-kreinin roni-kreinin self-assigned this Jul 6, 2023
@roni-kreinin roni-kreinin marked this pull request as ready for review July 6, 2023 20:08
---

The `clearpath_computer_setup` package offers a terminal menu tool for configuring a robot computer. The main feature of this tool is the ability to generate
`netplan` configurations. The `clearpath_comptuer_setup` package is available on the [Clearpath package server](../installation/robot.mdx#clearpath-package-server).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"clearpath_computer_setup"

Copy link
Collaborator

@jhiggins-cpr jhiggins-cpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple minor corrections.

Users who are installing ROS 2 Humble onto a new robot computer can skip to [Robot Installation](./robot).

:::

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a note of which robots are currently supported (aka only follow this if you have x robots)


If this is not the case, it is the responsibility of the user to ensure that any modified files and files in other users’ home folders is backed up correctly.

A common example of this might be if you have created customized URDF files to be loaded via environment variables (e.g. `JACKAL_URDF_EXTRAS`) and have stored them outside any of the folders specified above, you must back these up yourself; `backup.sh` will not do this for you.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is next? Can we directly call out the next step with a link? (I assume they need to follow the installation instructions).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a "next" button at the bottom that links to the robot installation page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the next button is always there even with unrelated pages, I think it would be a better user experience if we call out that they need to go to that next page, even if we are relying on the next button as the link. (Could say something along the lines of continue installation the same as with a new robot). Up to you though.

@roni-kreinin roni-kreinin merged commit 02e897c into ros2-humble Jul 7, 2023
@rhysfaultless-cpr rhysfaultless-cpr deleted the rkreinin/networking branch July 10, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants