-
Notifications
You must be signed in to change notification settings - Fork 12
Husky a300 AMP and Observer #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rhysfaultless-cpr
commented
May 30, 2025
- Added pages in the Solutions directory for both these robots. These pages are intended to capture all the hardware documentation, without having to navigate to the A300 page.
- Set up the pages for future Component reuse in the A300 page.
- Added centred-table CSS.
- Reduced image sizes to improve page loading time.
jhiggins-cpr
reviewed
Jun 2, 2025
jhiggins-cpr
reviewed
Jun 2, 2025
jhiggins-cpr
reviewed
Jun 2, 2025
jhiggins-cpr
reviewed
Jun 2, 2025
components/husky_a300/husky_a300_amp_other_documentation_to_review.mdx
Outdated
Show resolved
Hide resolved
jhiggins-cpr
reviewed
Jun 2, 2025
jhiggins-cpr
reviewed
Jun 2, 2025
jhiggins-cpr
reviewed
Jun 2, 2025
jhiggins-cpr
reviewed
Jun 2, 2025
jhiggins-cpr
reviewed
Jun 2, 2025
jhiggins-cpr
reviewed
Jun 2, 2025
jhiggins-cpr
reviewed
Jun 2, 2025
jhiggins-cpr
reviewed
Jun 2, 2025
jhiggins-cpr
reviewed
Jun 2, 2025
jhiggins-cpr
reviewed
Jun 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting so much thought and effort into these changes. I expect that this will be very helpful for customers, integrators, and client success. Mostly minor comments throughout. A few top-level points:
- Can we remove A200 Observer from the main Solutions and just keep it under ROS 1 Solutions?
- We may want to refine the AMP Getting Started section (to combine with OutdoorNav somewhat), but will cover that in a separate merge request.
- The section number is not working as expected. Specifically, the second number does not reset when the first number increments. For example, the AMP User Manual goes from Section 1. 5 to 2.6 (rather than 2.1).
- We should discuss the format for the safety admonitions that has been requested by the Rockwell safety team.
…links to route to the Legacy pages.
… on internal discussion for Inventus batteries.
jhiggins-cpr
approved these changes
Jun 2, 2025
Per @jhiggins-cpr earlier comments:
|
tonybaltovski
pushed a commit
that referenced
this pull request
Jul 7, 2025
* added AMP to /docs_robots/solutions/ * added A300 Observer to /docs_robots/solutions/ * removed A200 Observer from /docs_robots/solutions/ * reduced image sizes * moved content to /components for reuse in multiple pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.