Add format-spec rendering in display units (0.3.0)#2
Merged
Conversation
A non-empty format spec on a quantity now renders the value in display
units as a double, honoring the standard floating-point spec:
std::format("{:.1f}", millivolts(3300)) == "3.3V". SI-prefixed
precisions display in the base unit; conventional non-decade precisions
display in their conventional unit ("0.2Ah", never "720.0C"). Gains and
levels render in decibels: std::format("{:.1f}", 1050_cdB) == "10.5dB".
The empty spec keeps the exact-count form unchanged. Specs were
previously compile errors, so this is purely additive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors thermo-cpp's new formatter-side rendering (cleishm/thermo-cpp#5): a non-empty format spec on a quantity renders the value in display units as a double, honoring the full floating-point spec syntax. The empty spec keeps today's exact-count form unchanged.
_display_unittrait ("0.2Ah", never "720.0C") — analogous to thermo's fahrenheit display family.Test plan
-DCONFIG_ELECTRO_STD_FORMAT=0 -fsyntax-only