Skip to content

Align Expo bump review and Slack notification#797

Merged
swolfand merged 1 commit into
mainfrom
mike/align-expo-release-notification
Jul 10, 2026
Merged

Align Expo bump review and Slack notification#797
swolfand merged 1 commit into
mainfrom
mike/align-expo-release-notification

Conversation

@mikepitre

Copy link
Copy Markdown
Collaborator

The Android release workflow currently requests clerk/team-sdk on the generated clerk/javascript Expo bump PR. This change requests wobsoriano instead and treats a failed review request as a warning so it cannot fail the release job.

The Slack notification now follows the iOS release format: the release title, View the GitHub release, and, when a bump PR exists, View the Expo bump PR. It no longer adds extra status text when no Expo PR was opened.

Validated with actionlint while ignoring the repository's custom Blacksmith runner-label warning, git diff --check, and a rendered payload check.

@mikepitre mikepitre requested a review from swolfand July 9, 2026 20:59
@mikepitre mikepitre marked this pull request as ready for review July 9, 2026 21:00
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The manual release workflow now requests wobsoriano as an Expo PR reviewer without failing the workflow if the request is unsuccessful. Slack notification payload construction now assembles a context_links value containing the GitHub release link and, when available, the Expo bump PR link.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: swolfand

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main workflow change: Expo bump review alignment and Slack notification updates.
Description check ✅ Passed The description covers the required summary of changes and includes validation details, matching the template's intent.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

Review ran into problems

🔥 Problems

Linked repositories: Your configuration references 7 linked repositories, but your current plan allows 1. Analyzed clerk/clerk_go, skipped clerk/dashboard, clerk/accounts, clerk/backoffice, clerk/clerk, clerk/clerk-docs, clerk/cloudflare-workers.


Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/manual-release.yml (1)

494-507: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Use the release title in the Slack notification .github/workflows/manual-release.yml:483-507 still passes needs.publish.outputs.tag_name into both text fields, so the message shows the tag instead of the release title. Pass the release title through publish and use that value here.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/manual-release.yml around lines 494 - 507, The Slack
payload in the release notification is still using the tag value instead of the
release title. Update the publish job to expose the release title, then change
the notification payload in the manual release workflow to use that
release-title output in both the text and blocks fields. Refer to the publish
job outputs and the PAYLOAD generation block that currently reads
needs.publish.outputs.tag_name.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In @.github/workflows/manual-release.yml:
- Around line 494-507: The Slack payload in the release notification is still
using the tag value instead of the release title. Update the publish job to
expose the release title, then change the notification payload in the manual
release workflow to use that release-title output in both the text and blocks
fields. Refer to the publish job outputs and the PAYLOAD generation block that
currently reads needs.publish.outputs.tag_name.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1c89e7f6-6a13-4099-bfea-d08a40ad79c9

📥 Commits

Reviewing files that changed from the base of the PR and between dac39d5 and 5e6878e.

📒 Files selected for processing (1)
  • .github/workflows/manual-release.yml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)

@swolfand swolfand merged commit c92628f into main Jul 10, 2026
15 checks passed
@swolfand swolfand deleted the mike/align-expo-release-notification branch July 10, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants