Align Expo bump review and Slack notification#797
Conversation
📝 WalkthroughWalkthroughThe manual release workflow now requests Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Review ran into problems🔥 ProblemsLinked repositories: Your configuration references 7 linked repositories, but your current plan allows 1. Analyzed Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/manual-release.yml (1)
494-507: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winUse the release title in the Slack notification
.github/workflows/manual-release.yml:483-507still passesneeds.publish.outputs.tag_nameinto both text fields, so the message shows the tag instead of the release title. Pass the release title throughpublishand use that value here.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/manual-release.yml around lines 494 - 507, The Slack payload in the release notification is still using the tag value instead of the release title. Update the publish job to expose the release title, then change the notification payload in the manual release workflow to use that release-title output in both the text and blocks fields. Refer to the publish job outputs and the PAYLOAD generation block that currently reads needs.publish.outputs.tag_name.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/manual-release.yml:
- Around line 494-507: The Slack payload in the release notification is still
using the tag value instead of the release title. Update the publish job to
expose the release title, then change the notification payload in the manual
release workflow to use that release-title output in both the text and blocks
fields. Refer to the publish job outputs and the PAYLOAD generation block that
currently reads needs.publish.outputs.tag_name.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 1c89e7f6-6a13-4099-bfea-d08a40ad79c9
📒 Files selected for processing (1)
.github/workflows/manual-release.yml
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
clerk/clerk_go(manual)
The Android release workflow currently requests
clerk/team-sdkon the generatedclerk/javascriptExpo bump PR. This change requestswobsorianoinstead and treats a failed review request as a warning so it cannot fail the release job.The Slack notification now follows the iOS release format: the release title,
View the GitHub release, and, when a bump PR exists,View the Expo bump PR. It no longer adds extra status text when no Expo PR was opened.Validated with
actionlintwhile ignoring the repository's custom Blacksmith runner-label warning,git diff --check, and a rendered payload check.