feat(mcp): add fx as a supported MCP client - #460
Conversation
fx (https://fx.sh) loads MCP servers only from its user-global trusted profile ~/.fx/mcp.json and speaks Streamable HTTP natively, so it is the one client that skips the `clerk mcp run` stdio bridge: the entry is written as { "type": "http", "url": … } under top-level `mcp`, with the resolved URL embedded at install time. Detected via ~/.fx/. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 429bf15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Installing into an alias-form profile ({ "mcpServers": ... }) previously
wrote a fresh mcp map next to it, and fx gives mcp precedence — every
aliased server went dark. Reads and writes now migrate an alias-only
profile to canonical mcp first, the same migration fx performs on its own
writes; a profile that already has mcp keeps its ignored alias untouched.
Direct-URL fx entries carry no bridge argv, so a --name install against a
CLERK_MCP_URL override was invisible to list/doctor/uninstall. fx now
recognizes an http descriptor pointing at the currently resolved MCP URL
as ours while that override is active.
Also corrects the claim that fx never loads repo-local MCP files — fx
0.0.7 loads workspace .mcp.json servers behind per-workspace trust; the
user-global profile is still the right registration surface.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The alias migration now branches on key presence, matching fx's own mcp-orelse-mcpServers precedence: a present canonical key of any shape reaches getServerMap so a malformed profile fails with mcp_client_config_invalid instead of being silently rewritten, and a malformed alias migrates so validation rejects it too. Provenance matching canonicalizes both sides through URL.href — install stores resolveUrl()'s normalized form, so a raw override like HTTP://LOCALHOST:8787/mcp now still matches its stored entry. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe CLI adds fx as a supported MCP client. It writes direct Streamable HTTP entries to Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This PR adds fx as a supported MCP client and updates its registration, documentation, and tests. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 8 files. (2 skipped: 2 unsupported.)
Comment |
2 participants
Summary
Vercel asked us to support fx, their open-source terminal coding agent, in
clerk mcp install. fx speaks Streamable HTTP natively, so it's the one client whose entry points straight at the remote URL instead of going through theclerk mcp runstdio bridge.Changes
fxclient: detected via~/.fx/, registered by writing{ "type": "http", "url": … }under top-levelmcpin~/.fx/mcp.json— the user-global trusted profile (fx 0.0.7 also loads workspace.mcp.jsonservers, but those sit behind per-workspace trust; the profile needs none). Handles fx'smcpServersprofile alias by migrating alias-only profiles to canonicalmcp, and recognizes dev-override entries by URL so they stay visible tolist/doctor/uninstall.fx mcp add: the command exists in fx 0.0.7 but is newer than fx's published docs, so the file write keeps registration working on older fx binaries. The README dialect note carries the reasoning.Verified against a real fx 0.0.7 install: our written entry matches what
fx mcp add --transport httpproduces byte for byte, andfx mcp list --connectreports the Clerk server ready with both tools.Not planned
Preflight validation of the whole fx profile (malformed sibling descriptors, ambiguous root keys like
MCP-Servers). No file-backed client validates the target client's per-entry schema, mirroring fx's parser in TypeScript would drift with every fx release, and fx already rejects and reports those profiles through its own diagnostics.References
🤖 Generated with Claude Code