Skip to content

fix(clerk-js): Update cookie attributes for iframes#2668

Merged
SokratisVidros merged 1 commit intorelease/v4from
brk.fix/cookies-iframe-support
Jan 30, 2024
Merged

fix(clerk-js): Update cookie attributes for iframes#2668
SokratisVidros merged 1 commit intorelease/v4from
brk.fix/cookies-iframe-support

Conversation

@brkalow
Copy link
Copy Markdown
Member

@brkalow brkalow commented Jan 26, 2024

Description

Update how cookies are set such that they can be read from applications rendered in frames.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@brkalow brkalow requested a review from a team as a code owner January 26, 2024 19:27
@brkalow brkalow requested review from dimkl and removed request for a team January 26, 2024 19:27
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 26, 2024

🦋 Changeset detected

Latest commit: 983e377

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brkalow
Copy link
Copy Markdown
Member Author

brkalow commented Jan 26, 2024

!snapshot

@clerk-cookie
Copy link
Copy Markdown
Collaborator

Hey @brkalow - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 0.6.7-snapshot.v983e377
@clerk/clerk-js 4.68.6-snapshot.v983e377
@clerk/clerk-expo 0.20.2-snapshot.v983e377

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@0.6.7-snapshot.v983e377 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@4.68.6-snapshot.v983e377 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@0.20.2-snapshot.v983e377 --save-exact

@dimkl dimkl requested a review from nikosdouvlis January 30, 2024 13:08
@SokratisVidros SokratisVidros changed the base branch from release/v4 to main January 30, 2024 16:57
@SokratisVidros SokratisVidros changed the base branch from main to release/v4 January 30, 2024 17:00
@SokratisVidros
Copy link
Copy Markdown
Contributor

Fix for V5 #2688

@SokratisVidros SokratisVidros added this pull request to the merge queue Jan 30, 2024
Merged via the queue into release/v4 with commit 4660a49 Jan 30, 2024
@SokratisVidros SokratisVidros deleted the brk.fix/cookies-iframe-support branch January 30, 2024 17:12
SokratisVidros added a commit that referenced this pull request Jan 31, 2024
__client_uat is samesite=none
__session is samesite=lax
__clerk_db_jwt is samesite=lax
__initted is samesite=lax

Fixes #2668
nikosdouvlis added a commit that referenced this pull request Feb 1, 2024
* fix(clerk-js): Fix same site in ClerkJS cookies

__client_uat is samesite=none
__session is samesite=lax
__clerk_db_jwt is samesite=lax
__initted is samesite=lax

Fixes #2668

* Create slow-carrots-eat.md

---------

Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants