Skip to content

fix(clerk-js): Update cookie attributes for iframes #2668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SokratisVidros merged 1 commit into from
Jan 30, 2024
Merged

fix(clerk-js): Update cookie attributes for iframes #2668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chilly-crews-perform.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Update cookie setting to ensure cookies can be set to be read when an application is embedded in an iframe.
8 changes: 4 additions & 4 deletions packages/clerk-js/src/utils/cookies/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ export const createCookieHandler = () => {

const setClientUatCookie = (client: ClientResource | undefined) => {
const expires = addYears(Date.now(), 1);
const sameSite = 'Strict';
const secure = false;
const sameSite = inSecureCrossOriginIframe() ? IFRAME_SAME_SITE : DEFAULT_SAME_SITE;
const secure = inSecureCrossOriginIframe() || window.location.protocol === 'https:';

// '0' indicates the user is signed out
let val = '0';
Expand All @@ -67,8 +67,8 @@ export const createCookieHandler = () => {

const setDevBrowserCookie = (jwt: string) => {
const expires = addYears(Date.now(), 1);
const sameSite = DEFAULT_SAME_SITE;
const secure = false;
const sameSite = inSecureCrossOriginIframe() ? IFRAME_SAME_SITE : DEFAULT_SAME_SITE;
const secure = inSecureCrossOriginIframe() || window.location.protocol === 'https:';

return devBrowserCookie.set(jwt, {
expires,
Expand Down