Skip to content

chore(types): Deprecate supported_identifiers and remove supported_external_accounts#3089

Merged
panteliselef merged 2 commits intomainfrom
elef/sdk-1576-deprecate-supported_identifiers
Apr 2, 2024
Merged

chore(types): Deprecate supported_identifiers and remove supported_external_accounts#3089
panteliselef merged 2 commits intomainfrom
elef/sdk-1576-deprecate-supported_identifiers

Conversation

@panteliselef
Copy link
Copy Markdown
Contributor

Description

Neither are used in their respective classes and supported_external_accounts is not inside /environment response

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

…_external_accounts`

None of these are used in their respective classes and `supported_external_accounts` is not inside `/environment` response
@panteliselef panteliselef self-assigned this Apr 2, 2024
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 2, 2024

🦋 Changeset detected

Latest commit: a237eac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@clerk/clerk-js Minor
@clerk/types Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

@dimkl dimkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add those changes in the migration guide and the cli.
cc: @LekoArts , @jescalan

@panteliselef panteliselef enabled auto-merge (squash) April 2, 2024 14:56
@panteliselef panteliselef merged commit 9180c8b into main Apr 2, 2024
@panteliselef panteliselef deleted the elef/sdk-1576-deprecate-supported_identifiers branch April 2, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants