Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/famous-plums-fold.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': minor
'@clerk/types': minor
---

Deprecate `supported_identifiers` and remove `supported_external_accounts`.
3 changes: 0 additions & 3 deletions packages/clerk-js/src/core/test/fixtures.ts
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,7 @@ export const createSignIn = (signInParams: Partial<SignInJSON> = {}, user: Parti
identifier: signInParams.identifier,
object: 'sign_in',
second_factor_verification: signInParams.second_factor_verification,
supported_external_accounts: signInParams.supported_external_accounts,
supported_first_factors: signInParams.supported_first_factors,
supported_identifiers: signInParams.supported_identifiers,
supported_second_factors: signInParams.supported_second_factors,
user_data: {
first_name: user.first_name,
Expand Down Expand Up @@ -235,7 +233,6 @@ export const createSignUp = (signUpParams: Partial<SignUpJSON> = {}) => {
optional_fields: signUpParams.optional_fields,
phone_number: signUpParams.phone_number,
required_fields: signUpParams.required_fields,
supported_external_accounts: signUpParams.supported_external_accounts,
unsafe_metadata: signUpParams.unsafe_metadata,
unverified_fields: signUpParams.unverified_fields,
username: signUpParams.username,
Expand Down
2 changes: 0 additions & 2 deletions packages/types/src/json.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import type { SamlIdpSlug } from './saml';
import type { SessionStatus } from './session';
import type { SignInFirstFactor, SignInJSON, SignInSecondFactor } from './signIn';
import type { SignUpField, SignUpIdentificationField, SignUpStatus } from './signUp';
import type { OAuthStrategy } from './strategies';
import type { BoxShadow, Color, EmUnit, FontWeight, HexColor } from './theme';
import type { UserSettingsJSON } from './userSettings';
import type { CamelToSnake } from './utils';
Expand Down Expand Up @@ -80,7 +79,6 @@ export interface SignUpJSON extends ClerkResourceJSON {
optional_fields: SignUpField[];
missing_fields: SignUpField[];
unverified_fields: SignUpIdentificationField[];
supported_external_accounts: OAuthStrategy[];
username: string | null;
first_name: string | null;
last_name: string | null;
Expand Down
7 changes: 6 additions & 1 deletion packages/types/src/signIn.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ import type { AuthenticateWithWeb3Params } from './web3Wallet';

export interface SignInResource extends ClerkResource {
status: SignInStatus | null;
/**
* @deprecated This attribute will be removed in the next major version
*/
supportedIdentifiers: SignInIdentifier[];
supportedFirstFactors: SignInFirstFactor[];
supportedSecondFactors: SignInSecondFactor[];
Expand Down Expand Up @@ -227,8 +230,10 @@ export interface SignInJSON extends ClerkResourceJSON {
object: 'sign_in';
id: string;
status: SignInStatus;
/**
* @deprecated This attribute will be removed in the next major version
*/
supported_identifiers: SignInIdentifier[];
supported_external_accounts: OAuthStrategy[];
identifier: string;
user_data: UserDataJSON;
supported_first_factors: SignInFirstFactorJSON[];
Expand Down