fix(clerk-js): Avoid sending password when saml is enabled#3578
fix(clerk-js): Avoid sending password when saml is enabled#3578panteliselef merged 5 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 3470a88 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!snapshot |
|
Hey @tmilewski - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/chrome-extension@1.0.19-snapshot.vcc64bf8 --save-exact
npm i @clerk/clerk-js@5.7.1-snapshot.vcc64bf8 --save-exact
npm i @clerk/elements@0.8.0-snapshot.vcc64bf8 --save-exact
npm i @clerk/clerk-expo@1.2.2-snapshot.vcc64bf8 --save-exact
npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact
npm i @clerk/remix@4.1.2-snapshot.vcc64bf8 --save-exact |
|
!snapshot |
|
!snapshot |
|
Hey @panteliselef - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/chrome-extension@1.0.19-snapshot.v3470a88 --save-exact
npm i @clerk/clerk-js@5.7.1-snapshot.v3470a88 --save-exact
npm i @clerk/elements@0.8.0-snapshot.v3470a88 --save-exact
npm i @clerk/clerk-expo@1.2.2-snapshot.v3470a88 --save-exact
npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact
npm i @clerk/remix@4.1.2-snapshot.v3470a88 --save-exact
npm i @clerk/upgrade@1.0.8-snapshot.v3470a88 --save-exact |
Description
Video with the fixed flows
https://www.loom.com/share/54775174c83d4a23a00fda669789848b?sid=6149812c-9df7-43f1-b896-400c138b4791
This PR addresses an issue with our SignIn component due to the existence of the hidden password field.
Stale information in password managers would autofill email + password for email addresses that require SAML to be used. In that scenario, FAPi would return an field error that was not displayed in the component, causing frustration to end users that could not logged in.
The solution is to "detect" the intention of the end user, and quickly recover from it by signing them in, with password or with SAML.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change