fix(clerk-js): Improve solution for saml and hidden password field#3597
Merged
fix(clerk-js): Improve solution for saml and hidden password field#3597
Conversation
🦋 Changeset detectedLatest commit: ff03ba9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
commented
Jun 19, 2024
Comment on lines
+1
to
+2
| --- | ||
| --- |
Contributor
Author
There was a problem hiding this comment.
We already have a commit with a changeset :) and we have not released yet.
LekoArts
approved these changes
Jun 20, 2024
LekoArts
changed the title
LauraBeatris
pushed a commit
that referenced
this pull request
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make sure that for application without saml enabled we fallback to the previous logic. Follow-up to #3578
Resolves one failing e2e test
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change