Skip to content

Conversation

@alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Feb 10, 2025

Description

BEFORE AFTER
Screenshot 2025-02-10 at 4 13 50 PM Screenshot 2025-02-19 at 6 11 13 PM

Resolves SDKI-892

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: 26bc14d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 10:34pm

@alexcarpenter
Copy link
Member Author

#5159

@alexcarpenter alexcarpenter reopened this Feb 18, 2025
@alexcarpenter alexcarpenter marked this pull request as ready for review February 18, 2025 21:19
return (
<Animated asChild>
<Flex sx={{ width: '100%' }}>
<Flex>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djordjevanjek do you have a preference on width for the input? Right now it defaults to the default browser input width but we can specify 50% for example.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested bunch of different options, but your example of 50% is actually spot on, let's go with that :)

sx={{
width: '50%',
[mqu.sm]: {
width: 'auto',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile we use auto to avoid the field being to small. 50% felt to small.

Screenshot 2025-02-19 at 6 08 15 PM

@alexcarpenter alexcarpenter merged commit 0540920 into main Feb 20, 2025
31 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/fix-org-member-search branch February 20, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants