chore(clerk-js,types,localizations): Introduce minimum length for organization memberships search #5159

LauraBeatris · 2025-02-13T21:47:46Z

Description

Introduce minimum length to trigger organization memberships search query
Refactor and simplify debouncing logic to use useDebounce hook instead of relying on keyup event
Update search row width to be partial based on the parent

CleanShot.2025-02-13.at.20.31.57.mp4

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2025-02-13T21:47:50Z

🦋 Changeset detected

Latest commit: c264dc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages

Name	Type
@clerk/clerk-js	Minor
@clerk/types	Minor
@clerk/localizations	Minor
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/agent-toolkit	Patch
@clerk/astro	Patch
@clerk/backend	Patch
@clerk/elements	Patch
@clerk/expo-passkeys	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/nextjs	Patch
@clerk/nuxt	Patch
@clerk/react-router	Patch
@clerk/clerk-react	Patch
@clerk/remix	Patch
@clerk/shared	Patch
@clerk/tanstack-start	Patch
@clerk/testing	Patch
@clerk/themes	Patch
@clerk/ui	Patch
@clerk/vue	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-02-13T21:47:52Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 14, 2025 6:40pm

.changeset/tricky-spiders-jog.md

alexcarpenter · 2025-02-14T16:18:13Z

packages/clerk-js/src/ui/components/OrganizationProfile/MembersSearchForm.tsx

  return (
-    <Animated asChild>
-      <Flex sx={{ width: '100%' }}>
+    <Flex


We should follow up with descriptors for these elements. There currently is no way to target MemberSearchForm elements with the appearance prop.

Added a descriptor for the container on 8e0b49d

Now we have the following:

alexcarpenter · 2025-02-14T16:28:03Z

packages/clerk-js/src/ui/components/OrganizationProfile/MembersSearchForm.tsx

+      <Field.Root {...searchField}>
        <InputWithIcon
-          value={value}
+          {...searchField.props}


This is resulting in a bunch of warnings for passing invalid dom props.

😢 Ooff, thanks for catching that! I forgot to sanitize the input props... going to push a fix for that

Pushed a fix on 4a53af3 - we currently only rely on the blur + focus event handlers from the useFormControl context

LauraBeatris · 2025-02-14T20:20:50Z

I'll do another review through the changes next week, will avoid merging on a Friday

LauraBeatris · 2025-02-17T18:53:11Z

We decided to park these changes for now in favor of not affecting the UX here due to this "jump" behavior of the input validation.

FAPI PR has also been closed there we won't get a 4xx error even if the query gets sent with less than 3 characters.

Let's keep analyzing the logs for the query performance, and decide later to react on the FAPI data layer instead of forcing the UI to not trigger the query.

LauraBeatris self-assigned this Feb 13, 2025

clerk-cookie added the clerk-js label Feb 13, 2025

LauraBeatris force-pushed the laura/org-profile-members-search-validation branch from 905a136 to 89921a1 Compare February 13, 2025 21:48

vercel bot deployed to Preview February 13, 2025 21:49 View deployment

LauraBeatris force-pushed the laura/org-profile-members-search-validation branch from 89921a1 to 8e3956a Compare February 13, 2025 21:49

vercel bot deployed to Preview February 13, 2025 21:50 View deployment

LauraBeatris force-pushed the laura/org-profile-members-search-validation branch from 8e3956a to 4ba3605 Compare February 13, 2025 21:53

vercel bot deployed to Preview February 13, 2025 21:55 View deployment

LauraBeatris force-pushed the laura/org-profile-members-search-validation branch from 61cfb18 to 5f0b04c Compare February 13, 2025 22:40

clerk-cookie added the types label Feb 13, 2025

vercel bot deployed to Preview February 13, 2025 22:41 View deployment

LauraBeatris force-pushed the laura/org-profile-members-search-validation branch 4 times, most recently from c5df69c to 383e89e Compare February 13, 2025 23:02

vercel bot deployed to Preview February 13, 2025 23:03 View deployment

LauraBeatris force-pushed the laura/org-profile-members-search-validation branch from 52245bc to e829bb9 Compare February 13, 2025 23:24

vercel bot deployed to Preview February 13, 2025 23:25 View deployment

clerk-cookie added the localizations label Feb 13, 2025

vercel bot deployed to Preview February 13, 2025 23:32 View deployment

LauraBeatris force-pushed the laura/org-profile-members-search-validation branch from d97775f to 4de61aa Compare February 13, 2025 23:34

LauraBeatris marked this pull request as ready for review February 13, 2025 23:34

vercel bot deployed to Preview February 13, 2025 23:35 View deployment

LauraBeatris requested a review from a team February 13, 2025 23:35

alexcarpenter mentioned this pull request Feb 13, 2025

fix(clerk-js): Update org member search alignment #5126

Merged

9 tasks

anagstef reviewed Feb 14, 2025

View reviewed changes

.changeset/tricky-spiders-jog.md Show resolved Hide resolved

anagstef approved these changes Feb 14, 2025

View reviewed changes

nikospapcom approved these changes Feb 14, 2025

View reviewed changes

vercel bot deployed to Preview February 14, 2025 15:34 View deployment

LauraBeatris force-pushed the laura/org-profile-members-search-validation branch from 1574aae to 80f74c9 Compare February 14, 2025 15:36

vercel bot deployed to Preview February 14, 2025 15:37 View deployment

LauraBeatris force-pushed the laura/org-profile-members-search-validation branch 2 times, most recently from 75ef85c to f83adf0 Compare February 14, 2025 15:40

vercel bot deployed to Preview February 14, 2025 15:42 View deployment

LauraBeatris force-pushed the laura/org-profile-members-search-validation branch from 42f185d to c6beeaa Compare February 14, 2025 15:42

vercel bot deployed to Preview February 14, 2025 15:44 View deployment

LauraBeatris requested a review from panteliselef February 14, 2025 15:46

vercel bot deployed to Preview February 14, 2025 15:46 View deployment

alexcarpenter reviewed Feb 14, 2025

View reviewed changes

vercel bot deployed to Preview February 14, 2025 16:53 View deployment

LauraBeatris changed the title ~~chore(clerk-js): Introduce minimum length for organization memberships search~~ chore(clerk-js,types,localizations): Introduce minimum length for organization memberships search Feb 14, 2025

vercel bot had a problem deploying to Preview February 14, 2025 17:40 Failure

LauraBeatris added 11 commits February 14, 2025 15:39

Update input primitive to accept feedbackType prop

d05dc3e

Introduce field control for min length validation

4cc4573

Refactor debounce logic

bf6ccbf

Add localized key

851f2d4

Leverage input value state from field control

5e1bc35

Update changeset

e295d16

Remove state sync with effect

700f1a7

Add portuguese translation

d97e4eb

Rename MembersSearch to MembersSearchForm

53abf16

Sanitize input props

43ab187

Add element descriptor for container

c264dc2

LauraBeatris force-pushed the laura/org-profile-members-search-validation branch from 8e0b49d to c264dc2 Compare February 14, 2025 18:39

vercel bot deployed to Preview February 14, 2025 18:40 View deployment

LauraBeatris closed this Feb 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(clerk-js,types,localizations): Introduce minimum length for organization memberships search #5159

chore(clerk-js,types,localizations): Introduce minimum length for organization memberships search #5159

Uh oh!

LauraBeatris commented Feb 13, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Feb 13, 2025 •

edited

Loading

Uh oh!

vercel bot commented Feb 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

alexcarpenter Feb 14, 2025

Uh oh!

LauraBeatris Feb 14, 2025

Uh oh!

alexcarpenter Feb 14, 2025

Uh oh!

LauraBeatris Feb 14, 2025 •

edited

Loading

Uh oh!

LauraBeatris Feb 14, 2025

Uh oh!

LauraBeatris commented Feb 14, 2025

Uh oh!

LauraBeatris commented Feb 17, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

chore(clerk-js,types,localizations): Introduce minimum length for organization memberships search #5159

chore(clerk-js,types,localizations): Introduce minimum length for organization memberships search #5159

Uh oh!

Conversation

LauraBeatris commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-bot bot commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

alexcarpenter Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

LauraBeatris Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

alexcarpenter Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

LauraBeatris Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LauraBeatris Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

LauraBeatris commented Feb 14, 2025

Uh oh!

LauraBeatris commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

LauraBeatris commented Feb 13, 2025 •

edited

Loading

changeset-bot bot commented Feb 13, 2025 •

edited

Loading

vercel bot commented Feb 13, 2025 •

edited

Loading

LauraBeatris Feb 14, 2025 •

edited

Loading

LauraBeatris commented Feb 17, 2025 •

edited

Loading