fix(clerk-js): Correctly handle scroll lock for multiple modals #5233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: c5185c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
octoper
force-pushed
the
vaggelis/fix-muiltiple-modal-scroll-lock
branch
from
d400467 to
618b4b3
Compare
anagstef
approved these changes
Feb 25, 2025
tmilewski
approved these changes
Feb 25, 2025
9 tasks
panteliselef
approved these changes
Feb 25, 2025
wobsoriano
approved these changes
Feb 25, 2025
Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>
octoper
force-pushed
the
vaggelis/fix-muiltiple-modal-scroll-lock
branch
from
f065a0c to
1c0612d
Compare
panteliselef
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where when multiple components where open on to of each other the scroll-lock mechanism would not work correctly.
Before
CleanShot.2025-02-25.at.18.51.10.mp4
After
CleanShot.2025-02-25.at.18.49.55.mp4
Fixes USER-1277
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change