-
Notifications
You must be signed in to change notification settings - Fork 402
fix(clerk-js): Issue with scroll locking on modals #5244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: f85ee6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
299dbd2 to
df80fa7
Compare
|
!snapshot |
fad8387 to
9bab355
Compare
|
!snapshot |
|
Hey @octoper - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/chrome-extension@2.2.12-snapshot.v20250227153615 --save-exact
npm i @clerk/clerk-js@5.54.1-snapshot.v20250227153615 --save-exact
npm i @clerk/clerk-expo@2.8.1-snapshot.v20250227153615 --save-exact |
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Description
This fixes an issue with modal overlays which was introduced by a previous attempt that was fixing scroll locking PR
Using
FloatingOverlayin the previous PR was resulting some sites to break with the following errorChecklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change