Skip to content

Conversation

@octoper
Copy link
Member

@octoper octoper commented Feb 27, 2025

Description

This fixes an issue with modal overlays which was introduced by a previous attempt that was fixing scroll locking PR

Using FloatingOverlay in the previous PR was resulting some sites to break with the following error

Blocked aria-hidden on an element because its descendant retained focus. 
The focus must not be hidden from assistive technology users. 
Avoid using aria-hidden on a focused element or its ancestor. Consider using the inert attribute instead, which will also prevent focus. 
For more details, see the aria-hidden section of the WAI-ARIA specification at https://w3c.github.io/aria/#aria-hidden.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: f85ee6a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 9:30pm

@panteliselef
Copy link
Member

!snapshot

@octoper
Copy link
Member Author

octoper commented Feb 27, 2025

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @octoper - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 2.2.12-snapshot.v20250227153615
@clerk/clerk-js 5.54.1-snapshot.v20250227153615
@clerk/clerk-expo 2.8.1-snapshot.v20250227153615

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@2.2.12-snapshot.v20250227153615 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.54.1-snapshot.v20250227153615 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.8.1-snapshot.v20250227153615 --save-exact

Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
@octoper octoper requested a review from nikosdouvlis February 27, 2025 16:00
@octoper octoper changed the title fix(clerk-js): Issue with modal overlay fix(clerk-js): Issue with scroll locking on modals Feb 27, 2025
@octoper octoper marked this pull request as draft February 27, 2025 16:11
@octoper octoper marked this pull request as ready for review February 27, 2025 16:36
@octoper octoper enabled auto-merge (squash) February 27, 2025 17:14
@octoper octoper merged commit e7ff37f into main Feb 27, 2025
28 of 29 checks passed
@octoper octoper deleted the vaggelis/fix-overlay-issue-for-modals branch February 27, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants